hotfix: fix ignore emergency parameter not working #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix ignore emergency parameter not working Signed-off-by: tkhmy <[email protected]> * add comfortable stop condition Signed-off-by: tkhmy <[email protected]> * change comfortable stop condition Signed-off-by: tkhmy <[email protected]> --------- Signed-off-by: tkhmy <[email protected]>
tkhmy
approved these changes
Aug 20, 2024
yabuta
added a commit
that referenced
this pull request
Sep 26, 2024
* cancel announce (#107) * add fix going to depart and arrive announce (#108) (#111) * add fix going to depart and arrive announce * fix * reset flag when no schedule --------- Signed-off-by: tkhmy <[email protected]> Co-authored-by: Kah Hooi Tan <[email protected]> * fix ignore emergency parameter not working (#110) (#112) * fix ignore emergency parameter not working * add comfortable stop condition * change comfortable stop condition --------- Signed-off-by: tkhmy <[email protected]> Co-authored-by: Kah Hooi Tan <[email protected]> * add thread handlering (#109) (#113) * fix condition (#114) * remove unneccess step (#115) * feat: remove request library (#118) (#119) Signed-off-by: tkhmy <[email protected]> * add handling for force goal (#120) Signed-off-by: tkhmy <[email protected]> --------- Signed-off-by: tkhmy <[email protected]> Co-authored-by: Kah Hooi Tan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix ignore emergency parameter not working
add comfortable stop condition
change comfortable stop condition
Related Issue(required)
#110
Description(required)
上記を2.4.0にも入れます
Review Procedure(required)
Related PR(optional)
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
If you are adding new package following items are required:
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.